Fix missing IP on unifi_user bug #430
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| localDnsRecord := "" | ||
| if resp.LocalDNSRecordEnabled { | ||
| localDnsRecord = resp.LocalDNSRecord | ||
| d.Set("ip", localDnsRecord) |
There was a problem hiding this comment.
I don't think this is actually desirable, let's remove it
There was a problem hiding this comment.
@joshuaspence If we don't have this line, then isn't this PR essentially accomplishing nothing? 🤔
The idea is that if LocalDNSRecordEnabled is set to true, then we override the "ip" with the LocalDNSRecord
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for making this TF provider 😄.
I was trying to use this provider to get an IP address based on a known MAC address, but was getting null results back from the TF
dataresource. I manually checked the REST endpoint to make sure the data was available, which it was.After some investigation, I believe an unintentional bug was introduced in this PR which overwrites the IP even if there is no local DNS record found. I have added a conditional that only overwrites the IP if there is a local DNS record instead.
I have tested this locally and it works in my scenario now 😄