Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge from libcyphal #17

Merged
merged 5 commits into from
Aug 24, 2024
Merged

Merge from libcyphal #17

merged 5 commits into from
Aug 24, 2024

Conversation

serges147
Copy link
Collaborator

@serges147 serges147 commented Aug 24, 2024 •
edited
Loading

Hide whitespace is recommended

@serges147 serges147 self-assigned this Aug 24, 2024
pavel-kirienko
pavel-kirienko approved these changes Aug 24, 2024
View reviewed changes
Copy link
Owner

@pavel-kirienko pavel-kirienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks fine, but for the record, the removal method was not easy to write, so I recommend you take extra care that it's still sound. The removal algorithm is quite convoluted and easy to mess up

c++/cavl.hpp Outdated Show resolved Hide resolved
@pavel-kirienko pavel-kirienko linked an issue Aug 24, 2024 that may be closed by this pull request
Bug in move assignment #16
Closed
@serges147
Copy link
Collaborator Author

serges147 commented Aug 24, 2024 •
edited
Loading

I think it looks fine, but for the record, the removal method was not easy to write, so I recommend you take extra care that it's still sound. The removal algorithm is quite convoluted and easy to mess up

Yup, it is quite complex. I analyzed my changes twice, read an article about AVL trees, and of course all the tests are green. So, it looks fine for me as well. Not sure what extra mile I can do...

serges147 and others added 2 commits August 24, 2024 15:04
@serges147 @pavel-kirienko
Update c++/cavl.hpp
2579460 
Co-authored-by: Pavel Kirienko <pavel.kirienko@gmail.com>
@serges147
fix style
093b05d
@serges147 serges147 mentioned this pull request Aug 24, 2024
Closed
@serges147 serges147 merged commit 9579dd9 into main Aug 24, 2024
14 checks passed
@serges147 serges147 deleted the sshirokov/merge branch August 24, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel-kirienko pavel-kirienko pavel-kirienko approved these changes

Assignees

@serges147 serges147

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in move assignment
2 participants
@serges147 @pavel-kirienko