Fix: Remove deprecated site.mobileView from initialization #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… component rendering - Remove deprecated site.mobileView access during plugin initialization - Move mobile/desktop view detection to component rendering phase - Add @service site injection to component - Register both before/after outlets with conditional rendering - Fixes Discourse 3.5.0.beta9-dev deprecation warning for static-viewport-initialization
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a deprecation warning in Discourse 3.6.0.beta1-dev by refactoring mobile view detection from plugin initialization to component rendering phase, eliminating the use of deprecated site.mobileView during initialization.
- Move mobile view detection from initialization to component level using
@service site - Replace conditional outlet registration with conditional rendering logic
- Register both before and after outlets with conditional templates
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
assets/javascripts/discourse/initializers/initialize-discourse-post-badges.gjs
Show resolved
Hide resolved
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes deprecation warning in Discourse 3.6.0.beta1-dev by moving 'site mobileView check from plugininitialization to component rendering phase.
Changes:
Testing: