Silence Font Registration Warning #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KunJeongPark
commented
Dec 2, 2024
| guard UIFont(name: name, size: 10.0) == nil else { | ||
| return | ||
| } | ||
|
|
There was a problem hiding this comment.
If there is failure to instantiate this font, it most likely means the font is not registered, so it goes through with registering this font, otherwise it returns without registering.
There was a problem hiding this comment.
I was thinking if it would make sense to call it from the AppDelegate, so the registration logic is available globally throughout the app. This way i think we wouldn’t need to register it again in individual views later.
Just thinking out loud :)
There was a problem hiding this comment.
I think this font is used only in a few specific views, so it makes sense to initialize it only in the PaymentButtonFont.
sshropshire
approved these changes
Dec 2, 2024
GMALKHA
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
already registered font
Checklist
Authors