Added possibility to define Paysera application routes via environment variables #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please, fix the typo in "Tests" section of Readme: "bash runt_tests.sh " |
|
@aliaksandr-falei fixed |
Added WebToPay_EnvReader for decoupling WebToPay_Config from direct env variables interaction TODO: fix unit-tests
paysera-aliaksandr-fa
approved these changes
Oct 16, 2024
paysera-aliaksandr-fa
approved these changes
Oct 16, 2024
paysera-aliaksandr-fa
approved these changes
Oct 17, 2024
paysera-aliaksandr-fa
approved these changes
Oct 17, 2024
paysera-aliaksandr-fa
approved these changes
Oct 18, 2024
paysera-aliaksandr-fa
requested review from
ashamrov
and removed request for
ashamrov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using Paysera routes via constants, the possibility to define routes in environment variables is added. It may be useful for debugging
Added configuration object, which composes routes and other possible configs (
projectId,passwordfor now), instead of using arrayed configurations. So configurations are typed now