Provide detailed error messages for request verification with OpenSSL… #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexleopnet
force-pushed
the
detailed_error_messages_while_verifying_request
branch
2 times, most recently
from
dae6f6a to
dd973ab
Compare
anatoliyLegkiy
approved these changes
Jan 3, 2025
| @@ -56,7 +56,12 @@ public function validateAndParseData(array $requestData): array | |||
|
|
|||
| if (isset($requestData['ss1']) || isset($requestData['ss2'])) { | |||
| if (!$this->signer->checkSign($requestData)) { | |||
| throw new WebToPay_Exception_Callback('Invalid sign parameters, check $_GET length limit'); | |||
There was a problem hiding this comment.
I propose to stay old message and just add (concatenate) new to old one for better identify old error message with new
alexleopnet
force-pushed
the
detailed_error_messages_while_verifying_request
branch
from
dd973ab to
da9869f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… sign.