Tweak commerical biosamples discards algorithm

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: gfdata
 Title: Data Extraction for DFO PBS Groundfish Stocks
-Version: 0.1.2
+Version: 0.1.3
 Authors@R: c(
     person(c("Elise", "A."), "Keppel", role = "aut"),
     person(c("Sean", "C."), "Anderson",

NEWS.md

@@ -1,9 +1,16 @@
 # Updates to gfdata
 
+## 0.1.3 2024-07-17
+
+- For commercial biological samples: discards with a null sample source code are
+  now coded as discards instead of unknown.
+
 ## 2023-07-13
+
 - HBLL INS (ssid: 39, 40) are now included in the default call for `get_survey_sets()`
 
 ## 2019-05-2019
+
 - Year, month and catch calculation moved to sql code instead of tidy funcion 
 to reduce run time on already extracted data.
 - Beginning to adapt tidy_cpue_index to work for hook and line data in additon

inst/sql/get-comm-samples.sql

@@ -45,7 +45,7 @@ SELECT TRIP_START_DATE,
 		THEN 'KEEPERS'
 	WHEN SPECIES_CATEGORY_CODE = 1 AND SAMPLE_SOURCE_CODE = 3
 		THEN 'DISCARDS'
-	WHEN SPECIES_CATEGORY_CODE = 4 AND SAMPLE_SOURCE_CODE IN(1, 3)
+	WHEN SPECIES_CATEGORY_CODE = 4 AND (SAMPLE_SOURCE_CODE IS NULL OR SAMPLE_SOURCE_CODE IN(1, 3))
 		THEN 'DISCARDS'
 	ELSE 'UNKNOWN' END AS SAMPLING_DESC,
 	VESSEL_ID