title: fix youtube shorts and live urls #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think these worked even before the recent refactor, since there were no regexes in `youtube_title` to catch them.
Previously, urls containing the substring "http" match incorrectly. E.g. a message such as "foo https://docs.aiohttp.org/en/stable/index.html bar" would match the regex, but the url capture group would be "http.org/en/stable/index.html".
|
Added another fix for a longstanding subtle bug that touches some of the same lines of code |
|
LGTM. TYFYS. o7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think these worked even before the recent refactor, since there were no regexes in
youtube_titleto catch them.Examples which failed before but work now: