Merge pull request #363 from ZLLentz/tst_no_run

TST: fix an issue with the test suite failing to run
pcdshub · Apr 11, 2023 · 1aee4e0 · 1aee4e0
2 parents 7917557 + 55949b9
commit 1aee4e0
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/.github/workflows/standard.yml b/.github/workflows/standard.yml
@@ -10,6 +10,7 @@ on:
 jobs:
   standard:
     uses: pcdshub/pcds-ci-helpers/.github/workflows/python-standard.yml@master
+    secrets: inherit
     with:
       # The workflow needs to know the package name.  This can be determined
       # automatically if the repository name is the same as the import name.

diff --git a/docs/source/releases.rst b/docs/source/releases.rst
@@ -1,6 +1,21 @@
 Release History
 ###############
 
+v1.18.2 (2023-04-11)
+====================
+
+Maintenance
+-----------
+- Fix an issue where the test suite would not run with the latest
+  lightpath. This was a test-suite only bug, not a runtime
+  function bug.
+- Fix an issue where pypi/conda upload builds would not have
+  proper authentication.
+
+Contributors
+------------
+- zllentz
+
 
 v1.18.1 (2023-04-04)
 ====================

diff --git a/hutch_python/tests/test_tstpython.py b/hutch_python/tests/test_tstpython.py
@@ -36,7 +36,7 @@ def test_tstpython_scripts():
 
 try:
     import lightpath
-    lightpath_version = lightpath.__version__
+    lightpath_version = str(lightpath.__version__)
 except ImportError:
     lightpath_version = '0.0.0'
 
@@ -47,7 +47,7 @@ def test_tstpython_scripts():
                     reason=('IPython breaks in a pseudo-tty if any package '
                             'initializes colorama, ruining this test.'))
 @pytest.mark.skipif(
-    version.parse(lightpath.__version__) <= version.parse('1.0.0'),
+    version.parse(lightpath_version) <= version.parse('1.0.0'),
     reason='Need lightpath config read bugfix from PR#167'
 )
 def test_tstpython_ipython():