Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sl1k0 align #121

Merged
merged 6 commits into from
Aug 16, 2024
Merged

Sl1k0 align #121

merged 6 commits into from
Aug 16, 2024

Conversation

ghalym
Copy link
Contributor

@ghalym ghalym commented May 18, 2024

Description

Motivation and Context

How Has This Been Tested?

Where Has This Been Documented?

Screenshots (if appropriate):

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to fixed versions and not Always Newest
  • Code committed with pre-commit (alternatively pre-commit run --all-files)

@ghalym ghalym requested a review from joshc-slac May 18, 2024 01:09
joshc-slac
joshc-slac previously approved these changes May 18, 2024
Copy link

@joshc-slac joshc-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, followed testing live.

@joshc-slac
Copy link

linked PR: pcdshub/lcls-plc-kfe-gatt#9

# Conflicts:
#	plc-kfe-motion/kfe_motion/kfe_motion.tmc
…l1k0-align

# Conflicts:
#	plc-kfe-motion/kfe_motion/kfe_motion.tmc
@ghalym ghalym requested a review from tongju12 August 16, 2024 17:18
Copy link
Contributor

@tongju12 tongju12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved so we can move on for new tasks.

@ghalym ghalym merged commit 2f16fe9 into pcdshub:master Aug 16, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants