decoupling st1k4 from st3k4 when st3k4 is out and tune im2k0 lag para… #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZLLentz
reviewed
Jun 18, 2024
| eEnumSet := ENUM_EpicsInOut.OUT; | ||
| END_IF | ||
| *} END_IF |
There was a problem hiding this comment.
As always, it's ok to just delete these lines (we have version control to bring them back)
ZLLentz
reviewed
Jun 18, 2024
| @@ -1464,7 +1464,7 @@ Drive Status 4 (manually linked): | |||
| </Drive> | |||
| <Controller Name="Ctrl" CtrType="2"> | |||
| <CtrPara PriorControlFactor="1"> | |||
| <PosDiffControl Range="1"/> | |||
| <PosDiffControl Range="1" Time="0.1"/> | |||
There was a problem hiding this comment.
Which parameter is this? Position lag monitoring time, changing from "default" to 0.1s?
There was a problem hiding this comment.
yes, it was 0.02s, now it is 0.1s
ZLLentz
reviewed
Jun 18, 2024
| @@ -1462,7 +1462,7 @@ Drive Status 4 (manually linked): | |||
| </Drive> | |||
| <Controller Name="Ctrl" CtrType="1"> | |||
| <CtrPara PriorControlFactor="1"> | |||
| <PosDiffControl Range="0.1"/> | |||
| <PosDiffControl Range="0.2"/> | |||
There was a problem hiding this comment.
This isn't noted in the PR text but Tong has mentioned to me previously that this fails to complete a move once in a while with no obvious issues- widening the range here will probably mitigate this.
ZLLentz
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…meter
TMO requests to decouple ST1K4 with ST3K4 while ST3K4 is OUT.
When ST3K4 IN, ST1K4 IN
When ST3K4 OUT, ST1K4 is free to be IN or OUT
IM2K0 has lag monitoring error, tune the parameter
Motivation and Context
TMIO requests it to use ST1K4 to block beam when ST3K4 is out
How Has This Been Tested?
Nick and I tested by toggling a boolean instance, ST1K4 is working as expected but not test with the real ST3K4 moving(ST3K4 is not working back then due to RP work.
IM2K0 moves around 10 times without error
Where Has This Been Documented?
(https://jira.slac.stanford.edu/browse/ECS-5586)
Screenshots (if appropriate):
Pre-merge checklist
Always Newestpre-commit(alternativelypre-commit run --all-files)