Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable leak valve VAT590 and 2OO3 Reset function #117

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

janezg-SLAC
Copy link
Contributor

Description

2 Changes:

  1. I added r/w functionality for the two new CoE parameters for the variable leak valve VAT590. It will give scientists an option to limit the maximum opening of the valve during pressure control.

  2. 2OO3 Reset function. FIX setting reset output of the VFS_2OO3_Interface for one cycle. Moving the code out of the IO() because IO() is called 2 times in the VFS_2OO3_Interface function block, which set the reset output to FALSE in the same cycle, which means the reset output was never set to TRUE.

Motivation and Context

How Has This Been Tested?

Where Has This Been Documented?

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to Always Newest version (Library, *)
  • Committed with pre-commit or ran pre-commit run --all-files

@jyin999 jyin999 merged commit 5439d35 into pcdshub:master Jan 18, 2024
6 of 9 checks passed
@janezg-SLAC janezg-SLAC deleted the VAT590_2OO3 branch February 15, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants