Skip to content

Conversation

@Yushan-Wang
Copy link
Member

List of things to check before making a PR

Before merging your code, please check the following:

  • you have added a line describing your changes to the Changelog;
  • you have added unit tests for any new or improved feature;
  • In case you updated dependencies, you have checked pdi/docs/CheckList.md
  • you have checked your code format:
    • you have checked that you respect all conventions specified in CONTRIBUTING.md;
    • you have checked that the indentation and formatting conforms to the .clang-format;
    • you have documented with doxygen any new or changed function / class;
  • you have correctly updated the copyright headers:
    • your institution is in the copyright header of every file you (substantially) modified;
    • you have checked that the end-year of the copyright there is the current one;
  • you have updated the AUTHORS file:
    • you have added yourself to the AUTHORS file;
    • if this is a new contribution, you have added it to the AUTHORS file;
  • you have added everything to the user documentation:
    • any new CMake configuration option;
    • any change in the yaml config;
    • any change to the public or plugin API;
    • any other new or changed user-facing feature;
    • any change to the dependencies;
  • you have correctly linked your MR to one or more issues:
    • your MR solves an identified issue;
    • your commit contain the Fix #issue keyword to autoclose the issue when merged.

@Yushan-Wang Yushan-Wang linked an issue Mar 28, 2025 that may be closed by this pull request
@jbigot
Copy link
Member

jbigot commented Oct 27, 2025

What's the status of this one, @Yushan-Wang ?

@Yushan-Wang
Copy link
Member Author

What's the status of this one, @Yushan-Wang ?

We found some dev errors, such as "on_finalize" not properly coded, which results in a segfault at the finalization phase. We have notified Etienne and he is supposed to do some rewriting. With @jmorice91, we still have some issues installing Damaris.

@jbigot
Copy link
Member

jbigot commented Oct 28, 2025

Thanks for the feedback

…ding auto initialize without on_init event, and adding some cmake instruction in enforce finding of Damaris when Damaris_ROOT is provided.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Damaris plugin

4 participants