Skip to content

Conversation

@jmorice91
Copy link
Contributor

@jmorice91 jmorice91 commented Oct 2, 2025

!!!INSERT YOUR DESCRIPTION HERE!!!

List of things to check before making a PR

Before merging your code, please check the following:

  • you have added a line describing your changes to the Changelog;
  • you have added unit tests for any new or improved feature;
  • In case you updated dependencies, you have checked pdi/docs/CheckList.md
  • you have checked your code format:
    • you have checked that you respect all conventions specified in CONTRIBUTING.md;
    • you have checked that the indentation and formatting conforms to the .clang-format;
    • you have documented with doxygen any new or changed function / class;
  • you have correctly updated the copyright headers:
    • your institution is in the copyright header of every file you (substantially) modified;
    • you have checked that the end-year of the copyright there is the current one;
  • you have updated the AUTHORS file:
    • you have added yourself to the AUTHORS file;
    • if this is a new contribution, you have added it to the AUTHORS file;
  • you have added everything to the user documentation:
    • any new CMake configuration option;
    • any change in the yaml config;
    • any change to the public or plugin API;
    • any other new or changed user-facing feature;
    • any change to the dependencies;
  • you have correctly linked your MR to one or more issues:
    • your MR solves an identified issue;
    • your commit contain the Fix #issue keyword to autoclose the issue when merged.

@jmorice91 jmorice91 requested a review from JAuriac October 2, 2025 07:37
@jmorice91 jmorice91 linked an issue Oct 2, 2025 that may be closed by this pull request
JAuriac
JAuriac previously approved these changes Oct 16, 2025
@jbigot
Copy link
Member

jbigot commented Oct 27, 2025

What's the status on this one, @jmorice91, @benoitmartin88 ?

@benoitmartin88
Copy link
Member

@jbigot: I don't know.
@jmorice91: I do have questions: Why do we need this ? How do we test this ?

@jmorice91
Copy link
Contributor Author

jmorice91 commented Oct 30, 2025

@jbigot: I don't know. @jmorice91: I do have questions: Why do we need this ? How do we test this ?

I have only to change the changelog (cf Remark of @jbigot).
It is only to add a button for action pages as we have for the macos-ci to re-run the CI for this action.
It can be used to regenerate the webpage in case of.

How do we test this ? There is no test.

Ps: This PR is related also to pdidev/pdidev.github.io#6 that is ready to review

status = ready to revue

Copy link
Member

@jbigot jbigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member

@benoitmartin88 benoitmartin88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Yushan-Wang Yushan-Wang merged commit 1e8c1bb into pdidev:main Nov 17, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add workflow_dispatach in main

5 participants