Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to fix #13 #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leon1995
Copy link

@leon1995 leon1995 commented Oct 5, 2024

I created this pr on a suggestion of #13 (comment)
I am not sure whether this is correct or not. Please double check

Copy link

@fritzmg fritzmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You only added a PHP class containing a method. This will not suffice.

  1. The PHP class you created will clash with the PHP class already existing in the core.
  2. The PHP class and method will not do anything on its own. You likely wanted to create a callback, e.g. a config.onload callback. See the official documentation on how to create a such a callback.

@leon1995
Copy link
Author

Okay, this is getting too time consuming for one that has never worked with php before. Maybe someone else can pick it up from here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants