feat(FO-2205): add new images for r and jupyter
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peak-jiteshahuja
changed the title
r and jupyter
saurabh0402
reviewed
Sep 20, 2023
...ython/ds-pack/2.1.0-base-python-3.8.18/codeserver-proxy/jupyter_codeserver_proxy/__init__.py
Outdated
Show resolved
Hide resolved
saurabh0402
reviewed
Sep 21, 2023
saurabh0402
reviewed
Sep 21, 2023
...thon/ds-pack/2.1.0-base-python-3.10.13/codeserver-proxy/jupyter_codeserver_proxy/__init__.py
Show resolved
Hide resolved
saurabh0402
reviewed
Sep 21, 2023
saurabh0402
reviewed
Sep 21, 2023
| RUN curl -fsSL https://code-server.dev/install.sh \ | ||
| | sh -s -- --version 4.16.1 \ | ||
| && pip install --no-cache-dir ./codeserver-proxy | ||
|
|
There was a problem hiding this comment.
We don't have Projector Proxy installed in this image?
Can we mention that somewhere if not already done.
There was a problem hiding this comment.
We've actually removed it from readme from this image. Do we want to explicitly mention that it isn't installed ?
There was a problem hiding this comment.
Yeah, I think we should
saurabh0402
reviewed
Sep 21, 2023
Hey we aren't updating any existing images, so we wouldn't be fixing any issues with |
akshayjain04
approved these changes
Sep 21, 2023
akshayjain04
approved these changes
Sep 22, 2023
saurabh0402
approved these changes
Sep 22, 2023
* feat: install vscode cli in 2.1.0-base-python-3.10.13 * fix: add copy statement to dockerfile * feat: add scripts to manage tunnel * feat: add vscode cli to all 2.1.x workspace python images * feat: add scripts for tunneling * fix: copy statement for dockerfile * fix: setup script * fix: set correct perms for vscode-tunnel folder * feat: add node script for start command * refactor: add usage to scripts * feat: add tunneling scripts to other python images * docs: add readme for tunneling * refactor: log file path for tunneling * refactor: remove redundant scripts * feat: add error handling to setup script * refactor: remove redundant params * fix: add mkdir logs to dockerfile * fix: ad -R to chmod * feat: update script to handle device verification * refactor: add newline to scripts * fix: break loop when theres an expection * feat: try using bash for tunnel creation * feat: add scripts to other python versions * docs: update readme * refactor: remove unwanted code * docs: update readme to add vscode-cli * feat: try adding scripts to /usr/bin * refactor: add tunneling readme to docs folder * fix: add execute permissions to scripts * fix: broken build * docs: update readme * feat: update dockerfile and readme for other python images * refactor: tweak the print output function to limit output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Description of what this PR does. What have you added or changed, and why? If it fixes a bug or resolves a feature request, be sure to link to that issue.
This PR aims to add the following new images:
workspace-python-ds-pack-2.1.0-base-python-3.8.17workspace-python-ds-pack-2.1.0-base-python-3.9.18workspace-python-ds-pack-2.1.0-base-python-3.10.13workspace-python-ds-pack-2.1.0-base-python-3.11.5workspace-r-ds-pack-1.1.0-base-r-4.3.1More details cab be found in the JIRA ticket.
Review Checks
Please check if the PR fulfills these requirements:
Put an
xin the boxes that apply, Remove any lines that do not applyDependencies
Add links to any pull requests or documentation related to this pull request.
N/A
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Security Considerations
Are there any other security or data concerns to be aware of?
Please discuss the security implications/considerations relevant to the proposed change.
This may include...
Types of change
What kind of change does this Pull Request introduce?
Put an
xin the boxes that applyIf "Other" please specify
YOUR TEXT HERE
Testing
Please include steps that the reviewer can follow in order to test the changes
Verify if the new global images are working fine.
Other information
N/A