fix(deps): update dependency youtubei.js to v13.1.0 #3015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
bro stole renovate's job 💀 |
Contributor
Author
|
I was meaning for this to be like a hotfix. When renovate kicks in I intend to close this haha |
|
Hey just for my own information, which of the fixes in v13.1.0 fixes this downloader issue? |
Member
|
downloader: Might be LuanRT/YouTube.js@5aecd0a |
|
Did some more research and apparently it is because of a Jintr bug (didn't know it before today): LuanRT/Jinter#29 |
Contributor
|
As a note, the downloader plugin still breaks on a playlist download with > 100 tracks. PR #3022 filters out the additional item type, and resolves the download issues. |
|
I'm kinda new to GitHub, can you tell me how to apply this fix? |
Member
|
Uhh, you want the lazy way or the proper way? |
|
lazy way please? |
|
@ArjixWasTaken Don't worry, both are fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3007
Also fixes #2978