Skip to content

Conversation

cxntered
Copy link
Contributor

@cxntered cxntered commented Sep 9, 2025

adds authorization for websocket connections with bearer tokens (retrieved from the /auth/:id endpoint) using the ?token query param.
if a client is unauthorized, it closes the connection with status code 1008 (policy violation) with the message "Unauthorized".
not sure if this was the best way to implement authorization, but i am open to suggestions :>

@cxntered
Copy link
Contributor Author

cxntered commented Sep 9, 2025

if security is a concern (we are passing in the token directly in the url after all), passing in the token through the Sec-WebSocket-Protocol header could be an alternative, but i don't know if that's a major concern

@JellyBrick JellyBrick added the enhancement New feature or request label Sep 9, 2025
@JellyBrick
Copy link
Collaborator

@cxntered Your system appears to be affected by the color@5.0.1 vulnerability. We recommend checking your machine. See issue #3855 for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants