-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Improve video toggle plugin: replace dual buttons with single eye icon toggle #3913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·d="M12.0012·5C7.52354·5·3.73326·7.94288·2.45898·12C3.73324·16.0571·7.52354·19·12.0012·19C16.4788·19·20.2691·16.0571·21.5434·12C20.2691·7.94291·16.4788·5·12.0012·5Z"·stroke="currentColor"·stroke-width="2"·stroke-linecap="round"·stroke-linejoin="round"
with ⏎··········d="M12.0012·5C7.52354·5·3.73326·7.94288·2.45898·12C3.73324·16.0571·7.52354·19·12.0012·19C16.4788·19·20.2691·16.0571·21.5434·12C20.2691·7.94291·16.4788·5·12.0012·5Z"⏎··········stroke="currentColor"⏎··········stroke-width="2"⏎··········stroke-linecap="round"⏎··········stroke-linejoin="round"⏎········
🚫 [eslint] <stylistic/jsx-sort-props> reported by reviewdog 🐶
Props should be sorted alphabetically
🚫 [eslint] <stylistic/jsx-sort-props> reported by reviewdog 🐶
Props should be sorted alphabetically
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
🚫 [eslint] <stylistic/jsx-sort-props> reported by reviewdog 🐶
Props should be sorted alphabetically
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
🚫 [eslint] <stylistic/jsx-sort-props> reported by reviewdog 🐶
Props should be sorted alphabetically
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
🚫 [eslint] <stylistic/jsx-sort-props> reported by reviewdog 🐶
Props should be sorted alphabetically
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
🚫 [eslint] <stylistic/jsx-sort-props> reported by reviewdog 🐶
Props should be sorted alphabetically
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·d="M2.99902·3L20.999·21M9.8433·9.91364C9.32066·10.4536·8.99902·11.1892·8.99902·12C8.99902·13.6569·10.3422·15·11.999·15C12.8215·15·13.5667·14.669·14.1086·14.133M6.49902·6.64715C4.59972·7.90034·3.15305·9.78394·2.45703·12C3.73128·16.0571·7.52159·19·11.9992·19C13.9881·19·15.8414·18.4194·17.3988·17.4184M10.999·5.04939C11.328·5.01673·11.6617·5·11.9992·5C16.4769·5·20.2672·7.94291·21.5414·12C21.2607·12.894·20.8577·13.7338·20.3522·14.5"·stroke="currentColor"·stroke-width="2"·stroke-linecap="round"·stroke-linejoin="round"
with ⏎··········d="M2.99902·3L20.999·21M9.8433·9.91364C9.32066·10.4536·8.99902·11.1892·8.99902·12C8.99902·13.6569·10.3422·15·11.999·15C12.8215·15·13.5667·14.669·14.1086·14.133M6.49902·6.64715C4.59972·7.90034·3.15305·9.78394·2.45703·12C3.73128·16.0571·7.52159·19·11.9992·19C13.9881·19·15.8414·18.4194·17.3988·17.4184M10.999·5.04939C11.328·5.01673·11.6617·5·11.9992·5C16.4769·5·20.2672·7.94291·21.5414·12C21.2607·12.894·20.8577·13.7338·20.3522·14.5"⏎··········stroke="currentColor"⏎··········stroke-width="2"⏎··········stroke-linecap="round"⏎··········stroke-linejoin="round"⏎········
🚫 [eslint] <stylistic/jsx-sort-props> reported by reviewdog 🐶
Props should be sorted alphabetically
🚫 [eslint] <stylistic/jsx-sort-props> reported by reviewdog 🐶
Props should be sorted alphabetically
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
🚫 [eslint] <stylistic/jsx-sort-props> reported by reviewdog 🐶
Props should be sorted alphabetically
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·d="M2.99902·3L20.999·21M9.8433·9.91364C9.32066·10.4536·8.99902·11.1892·8.99902·12C8.99902·13.6569·10.3422·15·11.999·15C12.8215·15·13.5667·14.669·14.1086·14.133M6.49902·6.64715C4.59972·7.90034·3.15305·9.78394·2.45703·12C3.73128·16.0571·7.52159·19·11.9992·19C13.9881·19·15.8414·18.4194·17.3988·17.4184M10.999·5.04939C11.328·5.01673·11.6617·5·11.9992·5C16.4769·5·20.2672·7.94291·21.5414·12C21.2607·12.894·20.8577·13.7338·20.3522·14.5"·stroke="currentColor"·stroke-width="2"·stroke-linecap="round"·stroke-linejoin="round"
with ⏎··········d="M2.99902·3L20.999·21M9.8433·9.91364C9.32066·10.4536·8.99902·11.1892·8.99902·12C8.99902·13.6569·10.3422·15·11.999·15C12.8215·15·13.5667·14.669·14.1086·14.133M6.49902·6.64715C4.59972·7.90034·3.15305·9.78394·2.45703·12C3.73128·16.0571·7.52159·19·11.9992·19C13.9881·19·15.8414·18.4194·17.3988·17.4184M10.999·5.04939C11.328·5.01673·11.6617·5·11.9992·5C16.4769·5·20.2672·7.94291·21.5414·12C21.2607·12.894·20.8577·13.7338·20.3522·14.5"⏎··········stroke="currentColor"⏎··········stroke-width="2"⏎··········stroke-linecap="round"⏎··········stroke-linejoin="round"⏎········
🚫 [eslint] <stylistic/jsx-sort-props> reported by reviewdog 🐶
Props should be sorted alphabetically
🚫 [eslint] <stylistic/jsx-sort-props> reported by reviewdog 🐶
Props should be sorted alphabetically
Hello! I had an issue with the design of the toggle-video plugin, so I changed it to a simple icon, and the configuration is now applied correctly. I haven't seen the modes because I haven't focused on that, haha. The position of the thumbnail has also been improved because it used to move when hidden.