Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for php8.x #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add support for php8.x #21

wants to merge 1 commit into from

Conversation

horaciod
Copy link

@horaciod horaciod commented Jul 12, 2024

After doing some analysis of the errors found when running the tests in php 8.1 I made some changes to respect the strict types that are now required as return in SplDoublyLinkedList

avoiding +Fatal error: Uncaught TypeError: File_MARC_List::key(): Return value must be of type int, string returned in ... /MARC/List.php:101\n

I'm using integers instead of strings for keys in linked lists.
It is only necessary to convert the keys in the case of using them directly as in marc_list_001.phpt.
Also fixed some issues with parameters sent to the preg_match method.

@horaciod horaciod marked this pull request as draft July 12, 2024 22:56
@horaciod horaciod marked this pull request as ready for review July 13, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant