Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: copy update concerning oss and foss - chapter 1 #310

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

schalkneethling
Copy link

This updates some of the copy in chapter one to more accurately reflect the meaning of open source and the relationshiop to FOSS. This is based on an email thread of the teaching open source mailing list.

This updates some of the copy in chapter one to more accurately reflect the meaning
of open source and the relationshiop to FOSS. This is based on an email thread of the
teaching open source mailing list.
@emmet0r
Copy link
Contributor

emmet0r commented Apr 4, 2024

I think it could improve readability to add commas just before and after "also sometimes referred to as Free and Open Source Software (FOSS)" but this otherwise looks great to me 🙂

@schalkneethling
Copy link
Author

I think it could improve readability to add commas just before and after "also sometimes referred to as Free and Open Source Software (FOSS)" but this otherwise looks great to me 🙂

Good point!

Change based on review feedback.

Signed-off-by: Schalk Neethling <schalk@mechanical.ink>
Copy link

@AbcSxyZ AbcSxyZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #311 for controversy over « by anyone for any purpose ».

@pearcej
Copy link
Owner

pearcej commented Apr 8, 2024

I think the references to the licencing is an improvement, but we have lost the meaning of the word "open". @AbcSxyZ, @schalkneethling, and @emmet0r on the sentence "Open source is source code that is made freely available for possible modification and/or redistribution, depending upon the specific licensing."

@schalkneethling
Copy link
Author

schalkneethling commented Apr 8, 2024

I think the references to the licencing is an improvement, but we have lost the meaning of the word "open". @AbcSxyZ, @schalkneethling, and @emmet0r on the sentence "Open source is source code that is made freely available for possible modification and/or redistribution, depending upon the specific licensing."

Something like this:

Open source software, also called Free and Open Source Software (FOSS), is source code made freely available for possible modification and/or redistribution, depending upon the specific licensing.

Signed-off-by: Jan Pearce <jan_pearce@berea.edu>
@pearcej pearcej merged commit 01a1118 into pearcej:main Apr 8, 2024
1 check passed
@schalkneethling schalkneethling deleted the update-copy-chapter1 branch April 8, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants