Vypnutí pravidla SpaceBeforeNotSniff #51
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Důvod vypnutí:
S novým CS se objevil v určitých případech problém, kdy spolu kolidují 2 pravidla a tím pádem nefunguje cs-fix. Jedná se o případy typu:
kdy problém je ten řádek
->setAutowired(! $lazyConfigurationsMap)
. Problém je v tom, že naše pravidlo/Sniffs/Formatting/SpaceBeforeNotSniff.php
, které psali před nedávnem kluci ze SuperZOO, vyžaduje mezeru před!
. Po opravě by tedy vzniklo->setAutowired( ! $lazyConfigurationsMap)
, což je ale problém pro pravidloPSR2.Methods.FunctionCallSignature.SpaceAfterOpenBracket
, které vyžaduje 0 mezer po otevírací závorce volání funkce.