Merge pull request #24 from pedrohnv/dev

Release 0.2.1
pedrohnv · Oct 25, 2024 · 3951ea1 · 3951ea1 · pedrohnv · Oct 25, 2024
2 parents 093a02e + 5d7aeee
commit 3951ea1
Show file tree

Hide file tree

Showing 11 changed files with 448 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,7 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [Unreleased]
+## [0.2.1]
+
+### Fixed
+
+- variable `Npairs` to `Npoles` in `recommended_init_poles`
+- prevent InexactError if `f` or `poles` were `Float`
 
 ## [0.2.0] - 2024-10-08
 

diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "RationalVectorFitting"
 uuid = "52b1e31a-230f-50d6-be04-0f5494ddfff6"
 authors = ["Pedro H. N. Vieira <phnvieira@proton.me>"]
-version = "0.2.0"
+version = "0.2.1"
 
 [deps]
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"

diff --git a/docs/src/ex1.svg b/docs/src/ex1.svg
diff --git a/docs/src/ex2.svg b/docs/src/ex2.svg
diff --git a/docs/src/ex3-mag.svg b/docs/src/ex3-mag.svg
diff --git a/docs/src/ex3-phase.svg b/docs/src/ex3-phase.svg
diff --git a/docs/src/ex4-1.svg b/docs/src/ex4-1.svg
diff --git a/docs/src/ex4-2.svg b/docs/src/ex4-2.svg
diff --git a/docs/src/ex4-3.svg b/docs/src/ex4-3.svg
diff --git a/docs/src/ex4-4.svg b/docs/src/ex4-4.svg
diff --git a/src/RationalVectorFitting.jl b/src/RationalVectorFitting.jl
@@ -58,17 +58,17 @@ end
 
 
 """
-    recommended_init_poles(s, Npairs) -> init_poles
+    recommended_init_poles(s, Npoles) -> init_poles
 
 Builds a vector of recommended initial poles sorted by [`cplxpair`](@ref).
 """
-function recommended_init_poles(s, Npairs)
+function recommended_init_poles(s, Npoles)
     s0 = imag(s[1])
     if isapprox(s0, 0.0)
         s0 = imag(s[2])
     end
     s1 = imag(s[end])
-    init_poles = [(-0.01 + 1.0im) * sk for sk in range(s0, s1, length = Npairs ÷ 2)]
+    init_poles = [(-0.01 + 1.0im) * sk for sk in range(s0, s1, length = Npoles ÷ 2)]
     init_poles = sort!([init_poles; conj.(init_poles)], by = cplxpair)
     return init_poles
 end
@@ -206,7 +206,7 @@ See also [`vector_fitting`](@ref), [`pole_identification`](@ref).
 function residue_identification(s, f, poles, weight)
     Ns = length(s)
     Np = length(poles)
-    residues = similar(poles)
+    residues = similar(poles, ComplexF64)
     Nrows = 2 * Ns
     Ncols = Np + 2
     A1_cplx = zeros(ComplexF64, Ns, Ncols)
@@ -316,7 +316,7 @@ function vector_fitting(
     residues = zeros(ComplexF64, Np, Nc)
     d = zeros(Nc)
     h = zeros(Nc)
-    fitted = similar(f)
+    fitted = similar(f, ComplexF64)
     local error_norm = Inf
     for iter = 1:maxiter
         if error_norm < tol