Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text and background color #90

Merged
merged 5 commits into from
Jul 25, 2024

Conversation

AryanAhadinia
Copy link
Contributor

Now with activeTextColor, you can separately control icon and text color. I had implemented activeBackgroundColor, so you can even control background color separated from icon and text color. These are optional fields, so compatibility will be maintained.

This PR can close both issues #65 and #52.

@Raider-hub
Copy link

Hello, please this is exactly what I wanted. I'm a flutter beginner, please how can I implement this in my project. This changes you've made. I also need an active Background color

@Raider-hub
Copy link

THIS IS THE ERRORS IM GETTING

lib/screens/home/bottom_navigator.dart:92:13: Error: No named parameter with the name 'activeBackgroundColor'.
activeBackgroundColor: Colors.grey,
^^^^^^^^^^^^^^^^^^^^^
/D:/src/flutter/.pub-cache/hosted/pub.dartlang.org/bottom_navy_bar-6.0.0/lib/bottom_navy_bar.dart:194:3: Context: Found this candidate, but the arguments don't match.
BottomNavyBarItem({

^^^^^^^^^^^^^^^^^

@AryanAhadinia
Copy link
Contributor Author

Hello,
Because this changed hasn't merged with master yet. You can use this feature after @pedromassango publish new version or you can add these changes manually to your project.

@Raider-hub
Copy link

Hello,
Because this changed hasn't merged with master yet. You can use this feature after @pedromassango publish new version or you can add these changes manually to your project.

Okay I understand. But please can you show me how I can Add this manually?

@baptistesx
Copy link

Hey @pedromassango, could you check this PR and merge it if everything is ok please? :)

Thanks in advance !

@antonio-pedro99 antonio-pedro99 added this to the 7.0.0 milestone Jul 13, 2024
@antonio-pedro99 antonio-pedro99 self-requested a review July 13, 2024 23:49
@antonio-pedro99
Copy link
Collaborator

Now with activeTextColor, you can separately control icon and text color. I had implemented activeBackgroundColor, so you can even control background color separated from icon and text color. These are optional fields, so compatibility will be maintained.

This PR can close both issues #65 and #52.

Thanks for the contributions and sorry for being late.

I am now in charge of this package, I will be reviewing this PR very soon.
Yes, I added it to the upcoming version. Meanwhile, you can consider using the most recent version 6.1.0 with a lot of fixes :)

Copy link
Collaborator

@antonio-pedro99 antonio-pedro99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
Added some fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants