Skip to content

Fix unit tests and namespace generation for SchemaContext changes #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pedrosakuma merged 5 commits into from
Oct 30, 2025
Merged

Fix unit tests and namespace generation for SchemaContext changes #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
201a7a1
Initial plan
Copilot Oct 30, 2025
92ad113
Fix unit tests by adding schema key parameter to SchemaContext
Copilot Oct 30, 2025
2c65598
Fix MessagesCodeGenerator to use base namespace for runtime types and…
Copilot Oct 30, 2025
1f7a16c
Add version stripping to TypesCodeGenerator and UtilitiesCodeGenerator
Copilot Oct 30, 2025
071cb48
Revert problematic namespace changes from commits 2c65598 and 1f7a16c
Copilot Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/SbeCodeGenerator.Tests/DiagnosticsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public void Generate_WithInvalidIntegerAttribute_EmitsDiagnostic()

// Arrange
var generator = new TypesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");
var xmlDoc = new XmlDocument();
xmlDoc.LoadXml(@"
<messageSchema>
Expand All @@ -55,7 +55,7 @@ public void Generate_WithInvalidEnumFlagValue_CompletesSuccessfully()
{
// Arrange
var generator = new TypesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");
var xmlDoc = new XmlDocument();
xmlDoc.LoadXml(@"
<messageSchema>
Expand Down Expand Up @@ -83,7 +83,7 @@ public void Generate_WithInvalidOffset_CompletesSuccessfully()
{
// Arrange
var generator = new MessagesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");
var xmlDoc = new XmlDocument();
xmlDoc.LoadXml(@"
<sbe:messageSchema xmlns:sbe='http://fixprotocol.io/2016/sbe'>
Expand Down
8 changes: 4 additions & 4 deletions tests/SbeCodeGenerator.Tests/EndianTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public class EndianTests
public void SchemaContext_DefaultsByteOrder_IsLittleEndian()
{
// Arrange & Act
var context = new SchemaContext();
var context = new SchemaContext("test-schema");

// Assert
Assert.Equal("littleEndian", context.ByteOrder);
Expand All @@ -26,7 +26,7 @@ public void ParseSchema_WithLittleEndianAttribute_SetsLittleEndian()
byteOrder=""littleEndian"">
</sbe:messageSchema>");

var context = new SchemaContext();
var context = new SchemaContext("test-schema");

// Act
var messageSchemaNode = xmlDoc.DocumentElement;
Expand All @@ -53,7 +53,7 @@ public void ParseSchema_WithBigEndianAttribute_SetsBigEndian()
byteOrder=""bigEndian"">
</sbe:messageSchema>");

var context = new SchemaContext();
var context = new SchemaContext("test-schema");

// Act
var messageSchemaNode = xmlDoc.DocumentElement;
Expand All @@ -79,7 +79,7 @@ public void ParseSchema_WithoutByteOrderAttribute_DefaultsToLittleEndian()
<sbe:messageSchema xmlns:sbe=""http://fixprotocol.io/2016/sbe"">
</sbe:messageSchema>");

var context = new SchemaContext();
var context = new SchemaContext("test-schema");

// Act
var messageSchemaNode = xmlDoc.DocumentElement;
Expand Down
10 changes: 5 additions & 5 deletions tests/SbeCodeGenerator.Tests/MessagesCodeGeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public void Generate_WithSimpleMessage_ProducesMessageCode()
{
// Arrange
var generator = new MessagesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");
var xmlDoc = new XmlDocument();
xmlDoc.LoadXml(@"
<sbe:messageSchema xmlns:sbe='http://fixprotocol.io/2016/sbe'>
Expand Down Expand Up @@ -42,7 +42,7 @@ public void Generate_WithMessageContainingConstants_ProducesCodeWithConstants()
{
// Arrange
var generator = new MessagesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");
var xmlDoc = new XmlDocument();
xmlDoc.LoadXml(@"
<sbe:messageSchema xmlns:sbe='http://fixprotocol.io/2016/sbe'>
Expand All @@ -68,7 +68,7 @@ public void Generate_WithMultipleMessages_ProducesMultipleFiles()
{
// Arrange
var generator = new MessagesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");
var xmlDoc = new XmlDocument();
xmlDoc.LoadXml(@"
<sbe:messageSchema xmlns:sbe='http://fixprotocol.io/2016/sbe'>
Expand All @@ -95,7 +95,7 @@ public void Generate_WithDeprecatedFields_AddsObsoleteAttribute()
{
// Arrange
var generator = new MessagesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");
var xmlDoc = new XmlDocument();
xmlDoc.LoadXml(@"
<sbe:messageSchema xmlns:sbe='http://fixprotocol.io/2016/sbe'>
Expand Down Expand Up @@ -128,7 +128,7 @@ public void Generate_WithDeprecatedFieldWithSinceVersion_AddsVersionToObsoleteMe
{
// Arrange
var generator = new MessagesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");
var xmlDoc = new XmlDocument();
xmlDoc.LoadXml(@"
<sbe:messageSchema xmlns:sbe='http://fixprotocol.io/2016/sbe'>
Expand Down
4 changes: 2 additions & 2 deletions tests/SbeCodeGenerator.Tests/ParserCodeGeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public class MessageParsingHelpersTests
public void MessagesIncludeTryParseHelper()
{
// Arrange
var context = new SchemaContext();
var context = new SchemaContext("test-schema");
var xmlDoc = new XmlDocument();
xmlDoc.LoadXml(@"
<sbe:messageSchema xmlns:sbe='http://fixprotocol.io/2016/sbe'>
Expand All @@ -37,7 +37,7 @@ public void MessagesIncludeTryParseHelper()
public void CompositesIncludeTryParseHelper()
{
// Arrange
var context = new SchemaContext();
var context = new SchemaContext("test-schema");
var xmlDoc = new XmlDocument();
xmlDoc.LoadXml(@"
<sbe:messageSchema xmlns:sbe='http://fixprotocol.io/2016/sbe'>
Expand Down
18 changes: 9 additions & 9 deletions tests/SbeCodeGenerator.Tests/SnapshotTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public Task TypesCodeGenerator_GeneratesConsistentEnumCode()
{
// Arrange
var generator = new TypesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");

// Act
var results = generator.Generate("TestNamespace", _testSchema, context, default(SourceProductionContext));
Expand All @@ -48,7 +48,7 @@ public Task TypesCodeGenerator_GeneratesConsistentSetCode()
{
// Arrange
var generator = new TypesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");

// Act
var results = generator.Generate("TestNamespace", _testSchema, context, default(SourceProductionContext));
Expand All @@ -68,7 +68,7 @@ public Task TypesCodeGenerator_GeneratesConsistentCompositeCode()
{
// Arrange
var generator = new TypesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");

// Act
var results = generator.Generate("TestNamespace", _testSchema, context, default(SourceProductionContext));
Expand All @@ -87,7 +87,7 @@ public Task TypesCodeGenerator_GeneratesConsistentCompositeCode()
public Task MessagesCodeGenerator_GeneratesConsistentTradeMessage()
{
// Arrange
var context = new SchemaContext();
var context = new SchemaContext("test-schema");

// First run TypesCodeGenerator to populate the context
var typesGenerator = new TypesCodeGenerator();
Expand All @@ -97,7 +97,7 @@ public Task MessagesCodeGenerator_GeneratesConsistentTradeMessage()
var generator = new MessagesCodeGenerator();

// Act
var results = generator.Generate("TestNamespace", _testSchema, context, default(SourceProductionContext));
var results = generator.Generate("TestNamespace.V0", _testSchema, context, default(SourceProductionContext));

// Find the Trade message
var messageResult = results.FirstOrDefault(r => r.name.Contains("Trade") && !r.name.Contains("Parser"));
Expand All @@ -113,7 +113,7 @@ public Task MessagesCodeGenerator_GeneratesConsistentTradeMessage()
public Task MessagesCodeGenerator_GeneratesConsistentQuoteMessage()
{
// Arrange
var context = new SchemaContext();
var context = new SchemaContext("test-schema");

// First run TypesCodeGenerator to populate the context
var typesGenerator = new TypesCodeGenerator();
Expand All @@ -123,7 +123,7 @@ public Task MessagesCodeGenerator_GeneratesConsistentQuoteMessage()
var generator = new MessagesCodeGenerator();

// Act
var results = generator.Generate("TestNamespace", _testSchema, context, default(SourceProductionContext));
var results = generator.Generate("TestNamespace.V0", _testSchema, context, default(SourceProductionContext));

// Find the Quote message
var messageResult = results.FirstOrDefault(r => r.name.Contains("Quote") && !r.name.Contains("Parser"));
Expand All @@ -140,7 +140,7 @@ public Task UtilitiesCodeGenerator_GeneratesConsistentNumberExtensions()
{
// Arrange
var generator = new UtilitiesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");

// Act
var results = generator.Generate("TestNamespace", _testSchema, context, default(SourceProductionContext));
Expand All @@ -157,7 +157,7 @@ public Task UtilitiesCodeGenerator_GeneratesConsistentEndianHelpers()
{
// Arrange
var generator = new UtilitiesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");

// Act
var results = generator.Generate("TestNamespace", _testSchema, context, default(SourceProductionContext));
Expand Down
4 changes: 2 additions & 2 deletions tests/SbeCodeGenerator.Tests/Snapshots/MessagesCodeGenerator.Message.Quote.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
using TestNamespace;
using TestNamespace.Runtime;
using TestNamespace.V0;
using TestNamespace.V0.Runtime;
using System.Runtime.InteropServices;
namespace TestNamespace.V0;
/// <summary>
Expand Down
4 changes: 2 additions & 2 deletions tests/SbeCodeGenerator.Tests/Snapshots/MessagesCodeGenerator.Message.Trade.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
using TestNamespace;
using TestNamespace.Runtime;
using TestNamespace.V0;
using TestNamespace.V0.Runtime;
using System.Runtime.InteropServices;
namespace TestNamespace.V0;
/// <summary>
Expand Down
26 changes: 13 additions & 13 deletions tests/SbeCodeGenerator.Tests/TypesCodeGeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public void Generate_WithSimpleEnum_ProducesEnumCode()
{
// Arrange
var generator = new TypesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");
var xmlDoc = new XmlDocument();
xmlDoc.LoadXml(@"
<messageSchema>
Expand Down Expand Up @@ -43,7 +43,7 @@ public void Generate_WithSimpleType_ProducesTypeCode()
{
// Arrange
var generator = new TypesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");
var xmlDoc = new XmlDocument();
xmlDoc.LoadXml(@"
<messageSchema>
Expand All @@ -68,7 +68,7 @@ public void Generate_WithComposite_ProducesCompositeCode()
{
// Arrange
var generator = new TypesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");
var xmlDoc = new XmlDocument();
xmlDoc.LoadXml(@"
<messageSchema>
Expand Down Expand Up @@ -96,7 +96,7 @@ public void Generate_WithSet_ProducesSetCode()
{
// Arrange
var generator = new TypesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");
var xmlDoc = new XmlDocument();
xmlDoc.LoadXml(@"
<messageSchema>
Expand Down Expand Up @@ -128,7 +128,7 @@ public void Generate_TypeDefinition_IncludesReadonlyModifier()
{
// Arrange
var generator = new TypesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");
var xmlDoc = new XmlDocument();
xmlDoc.LoadXml(@"
<messageSchema>
Expand All @@ -153,7 +153,7 @@ public void Generate_TypeDefinition_IncludesConstructor()
{
// Arrange
var generator = new TypesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");
var xmlDoc = new XmlDocument();
xmlDoc.LoadXml(@"
<messageSchema>
Expand All @@ -178,7 +178,7 @@ public void Generate_TypeDefinition_IncludesImplicitConversion()
{
// Arrange
var generator = new TypesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");
var xmlDoc = new XmlDocument();
xmlDoc.LoadXml(@"
<messageSchema>
Expand All @@ -203,7 +203,7 @@ public void Generate_TypeDefinition_IncludesExplicitConversion()
{
// Arrange
var generator = new TypesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");
var xmlDoc = new XmlDocument();
xmlDoc.LoadXml(@"
<messageSchema>
Expand All @@ -228,7 +228,7 @@ public void Generate_TypeDefinition_AllPhase1Features_IntegrationTest()
{
// Arrange
var generator = new TypesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");
var xmlDoc = new XmlDocument();
xmlDoc.LoadXml(@"
<messageSchema>
Expand Down Expand Up @@ -262,7 +262,7 @@ public void Generate_RefStruct_IncludesReadonlyModifier()
{
// Arrange - Phase 3 Option 1: readonly ref structs
var generator = new TypesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");
var xmlDoc = new XmlDocument();
xmlDoc.LoadXml(@"
<messageSchema>
Expand Down Expand Up @@ -295,7 +295,7 @@ public void Generate_RefStruct_IncludesConstructor()
{
// Arrange - Phase 3 Option 1: ref struct constructors
var generator = new TypesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");
var xmlDoc = new XmlDocument();
xmlDoc.LoadXml(@"
<messageSchema>
Expand Down Expand Up @@ -326,7 +326,7 @@ public void Generate_RefStruct_CreateMethodUsesConstructor()
{
// Arrange - Phase 3 Option 1: Create method should use constructor
var generator = new TypesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");
var xmlDoc = new XmlDocument();
xmlDoc.LoadXml(@"
<messageSchema>
Expand Down Expand Up @@ -358,7 +358,7 @@ public void Generate_BlittableComposite_RemainsUnchanged()
{
// Arrange - Blittable composites should NOT be readonly ref structs
var generator = new TypesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");
var xmlDoc = new XmlDocument();
xmlDoc.LoadXml(@"
<messageSchema>
Expand Down
10 changes: 5 additions & 5 deletions tests/SbeCodeGenerator.Tests/UtilitiesCodeGeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public void Generate_ProducesNumberExtensions()
{
// Arrange
var generator = new UtilitiesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");
var xmlDoc = new XmlDocument();
xmlDoc.LoadXml("<messageSchema></messageSchema>");

Expand All @@ -32,7 +32,7 @@ public void Generate_ProducesEndianHelpers()
{
// Arrange
var generator = new UtilitiesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");
var xmlDoc = new XmlDocument();
xmlDoc.LoadXml("<messageSchema></messageSchema>");

Expand All @@ -51,7 +51,7 @@ public void Generate_UsesProvidedNamespace()
{
// Arrange
var generator = new UtilitiesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");
var xmlDoc = new XmlDocument();
xmlDoc.LoadXml("<messageSchema></messageSchema>");

Expand All @@ -69,7 +69,7 @@ public void Generate_ProducesSpanReader()
{
// Arrange
var generator = new UtilitiesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");
var xmlDoc = new XmlDocument();
xmlDoc.LoadXml("<messageSchema></messageSchema>");

Expand All @@ -88,7 +88,7 @@ public void Generate_ProducesSpanWriter()
{
// Arrange
var generator = new UtilitiesCodeGenerator();
var context = new SchemaContext();
var context = new SchemaContext("test-schema");
var xmlDoc = new XmlDocument();
xmlDoc.LoadXml("<messageSchema></messageSchema>");

Expand Down
Loading