Remove error-prone encoding APIs, enforce schema order at compile-time #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements PR #77 proposal: removes
BeginEncoding()and publicTryEncode*()helper methods that allowed encoding groups/varData in incorrect order, causing silent data corruption.Changes
MessageDefinition.cs: Made
BeginEncoding(),TryEncode{GroupName}(), andTryEncode{VarDataName}()privateTryEncode()methods onlyTests: Updated to use comprehensive
TryEncode()APIDocumentation: Updated README.md and ENCODING_ORDER_FIX.md
API
Before (Error-Prone)
After (Compile-Time Safe)
Method signature enforces schema order. Wrong parameter order = compilation error.
Breaking Change
BeginEncoding()or individualTryEncode*()methods will not compile. Migration requires switching to comprehensiveTryEncode().Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.