Typedef changes #206
Typedef changes #206
Conversation
4manasa
force-pushed
the
typedefFixes
branch
from
892b69b to
aa7ef5a
Compare
src/components/DeferLoad/index.ts
Outdated
| @@ -102,6 +102,7 @@ class DeferLoad extends BridgeBase { | |||
| .getActionsApi() | |||
| .showData(this.name, dataContext, dataContextParameters, { | |||
| skipSemanticUrl: true, | |||
| // @ts-ignore | |||
There was a problem hiding this comment.
Can you leave a comment as to why this ts-ignore is needed so we can pass this back to core team
src/components/DeferLoad/index.ts
Outdated
| @@ -114,13 +115,15 @@ class DeferLoad extends BridgeBase { | |||
| // Rendering defer loaded tabs in case/ page context | |||
| this.thePConn | |||
| .getActionsApi() | |||
| // @ts-ignore | |||
There was a problem hiding this comment.
Can you leave a comment as to why this ts-ignore is needed so we can pass this back to core team
| @@ -120,7 +120,8 @@ class ListView extends BridgeBase { | |||
| const theConfigProps = this.thePConn?.getConfigProps(); | |||
| if (theConfigProps) { | |||
| this.selectionMode = theConfigProps.selectionMode; | |||
| const componentConfig = this.thePConn.getRawMetadata().config; | |||
| // @ts-ignore | |||
There was a problem hiding this comment.
Can you leave an accurate description of the issue. For example:
// @ts-ignore - required because ComponentMetadataConfig does not have config object in type def
| @@ -183,6 +183,7 @@ class SimpleTableSelect extends BridgeBase { | |||
| parameters: this.parameters | |||
| }; | |||
|
|
|||
| // @ts-ignore | |||
There was a problem hiding this comment.
Reason for ts-ignore please
|
@4manasa , how come we missed all these changes in typedefs package upgrade PR?? |
| @@ -183,7 +183,7 @@ class SimpleTableSelect extends BridgeBase { | |||
| parameters: this.parameters | |||
| }; | |||
|
|
|||
| const filters = this.thePConn.getRawMetadata().config.promotedFilters ?? []; | |||
| const filters = (this.thePConn.getRawMetadata() as any).config.promotedFilters ?? []; | |||
There was a problem hiding this comment.
Replace unnecessary cast to any with // @ts-ignore - promotedFilters missing from types
| @@ -24,7 +24,8 @@ export class BridgeBase extends LitElement { | |||
| @property({ attribute: false, type: String }) validateMessage; | |||
| @property({ attribute: false, type: Object }) theComponentStyleTemplate: any = nothing; // Any styling lit-html template that should be added to renderTemplates | |||
|
|
|||
| @property({ attribute: false, type: Object }) thePConn; // Normalize incoming pConn to a PConnect object | |||
| // @ts-ignore | |||
| @property({ attribute: false }) thePConn: typeof PConnect; // Normalize incoming pConn to a PConnect object | |||
There was a problem hiding this comment.
The type of the "pConn" below needs to be defined too since we're using that also in the components and without it being defined, typings won't work in those cases.
There was a problem hiding this comment.
pConn below is not of type PConnect and we are not using much in the components.
There was a problem hiding this comment.
We should only be referring to thePConn as it goes through normalization (for some reason I still don't quite understand). Any references to this.pConn are likely incorrect outside of BridgeBase.
There was a problem hiding this comment.
Yeah, it's quite confusing also. We need to remove these occurrences probably in the future release.
No description provided.