Fixed the issues identified during adoption testing #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4manasa
requested review from
tumms2021389,
samhere06,
niallriddell and
vishalshrm539
src/components/fields/Date/index.ts
Outdated
| @@ -104,6 +104,7 @@ class DateComponent extends FormComponentBase { | |||
| id=${this.theComponentId} | |||
| name="DateOnly" | |||
| dataTestId=${this.testId} | |||
| .value=${dateValue} | |||
There was a problem hiding this comment.
Is this needed? Since the value property will be overwritten in the LionInputDatetime class anyways?
There was a problem hiding this comment.
yes, missed to remove while raising PR, updated now.
| @@ -109,6 +109,7 @@ class DateTime extends FormComponentBase { | |||
| id=${this.theComponentId} | |||
| name="DateTime" | |||
| dataTestId=${this.testId} | |||
| .value=${dateTimeValue} | |||
There was a problem hiding this comment.
Same as above comment.
src/components/MultiStep/index.ts
Outdated
| return sStyle; | ||
| } | ||
|
|
||
| _showHLine(index: number): boolean { | ||
| // eslint-disable-next-line sonarjs/prefer-single-boolean-return | ||
| if (index < this.arNavigationSteps.length - 1) { |
There was a problem hiding this comment.
Can change this method to: return index < this.arNavigationSteps.length - 1 to be more leaner.
vishalshrm539
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date and DateTime value not displaying on screen change issue fixed.
Multi step and Stages style issues fixed.