updated components to display formatting in readonly #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samhere06
requested review from
niallriddell,
vishalshrm539,
4manasa,
paulgagnon-pega and
tumms2021389
samhere06
force-pushed
the
mod/tot/readOnyFormat
branch
from
b98ac64 to
a85253d
Compare
samhere06
force-pushed
the
mod/tot/readOnyFormat
branch
from
a85253d to
fa947cb
Compare
niallriddell
approved these changes
Nov 4, 2024
| const theContent = html` | ||
| <lion-input-amount | ||
| id=${this.theComponentId} | ||
| ?readonly=${this.bReadonly} | ||
| ?visible=${this.bVisible} |
There was a problem hiding this comment.
Not sure it's necessary to set visible - we early return if it's not visible and the default for visible is true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated components to display formatting in readonly