Skip to content

Commit

Permalink
feat(autocomplete): Rename jumpy tests to jitter
Browse files Browse the repository at this point in the history
"jumpy" was an old term we used that isn't as clear or nice sounding as
"jitter"
  • Loading branch information
orangejulius committed Jun 6, 2019
1 parent 005b391 commit b30e4e6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions lib/analyze_results.js
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ function count_autocomplete_fails_search_passes(testSuites) {
/*
* Count the number of test cases where autocomplete passes, but then
* when more of the full text input is typed, it fails. This really confuses users
* and causes them to report autocomplete "jumpiness" which we really want to avoid
* and causes them to report autocomplete "jitter" which we really want to avoid
*/
function testCaseAutocompletePassesThenFails(testCase) {
var hasPassed = false;
Expand All @@ -91,7 +91,7 @@ function testCaseAutocompletePassesThenFails(testCase) {
// once one autocomplete test has passed, take note for later tests
hasPassed = hasPassed || testPassed;

// if this test failed but previous passed, this is a jumpy result
// if this test failed but previous passed, this is a result with jitter
return hasPassed && !testPassed;
});
}
Expand Down
2 changes: 1 addition & 1 deletion output_generators/autocomplete.js
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ function prettyPrintSuiteResults( suiteResults, config, testSuites ){

console.log( '\nAutocomplete stats'.blue);
console.log( 'Search passes but autocomplete fails: ' + suiteResults.autocomplete.autocomplete_fails_search_passes );
console.log( 'Jumpy autocomplete cases: ' + suiteResults.autocomplete.autocomplete_passes_then_fails );
console.log( 'Tests with jitter: ' + suiteResults.autocomplete.autocomplete_passes_then_fails );
console.log( 'Tests that pass only on last character: ' + suiteResults.autocomplete.only_last_character_passes );

console.log( '\nAggregate test results'.blue );
Expand Down

0 comments on commit b30e4e6

Please sign in to comment.