move consts from resouce into enum & model

pelican-dev · Sep 19, 2024 · 6ff4083 · 6ff4083
1 parent 16dbb53
commit 6ff4083
Show file tree

Hide file tree

Showing 4 changed files with 52 additions and 42 deletions.
diff --git a/app/Enums/RolePermissionModels.php b/app/Enums/RolePermissionModels.php
@@ -0,0 +1,16 @@
+<?php
+
+namespace App\Enums;
+
+enum RolePermissionModels: string
+{
+    case ApiKey = 'apikey';
+    case DatabaseHost = 'databasehost';
+    case Database = 'database';
+    case Egg = 'egg';
+    case Mount = 'mount';
+    case Node = 'node';
+    case Role = 'role';
+    case Server = 'server';
+    case User = 'user';
+}
diff --git a/app/Enums/RolePermissionPrefixes.php b/app/Enums/RolePermissionPrefixes.php
@@ -0,0 +1,12 @@
+<?php
+
+namespace App\Enums;
+
+enum RolePermissionPrefixes: string
+{
+    case ViewAny = 'viewList';
+    case View = 'view';
+    case Create = 'create';
+    case Update = 'update';
+    case Delete = 'delete';
+}
diff --git a/app/Filament/Resources/RoleResource.php b/app/Filament/Resources/RoleResource.php
@@ -2,6 +2,8 @@
 
 namespace App\Filament\Resources;
 
+use App\Enums\RolePermissionModels;
+use App\Enums\RolePermissionPrefixes;
 use App\Filament\Resources\RoleResource\Pages;
 use App\Models\Role;
 use Filament\Facades\Filament;
@@ -30,61 +32,27 @@ public static function getNavigationBadge(): ?string
         return static::getModel()::count() ?: null;
     }
 
-    private const PERMISSION_MODELS = [
-        'ApiKey',
-        'DatabaseHost',
-        'Database',
-        'Egg',
-        'Mount',
-        'Node',
-        'Role',
-        'Server',
-        'User',
-    ];
-
-    private const PERMISSION_PREFIXES = [
-        'viewList',
-        'view',
-        'create',
-        'update',
-        'delete',
-    ];
-
-    private const MODEL_SPECIFIC_PERMISSIONS = [
-        'Egg' => [
-            'import',
-            'export',
-        ],
-    ];
-
-    private const SPECIAL_PERMISSIONS = [
-        'Settings' => [
-            'view',
-            'update',
-        ],
-    ];
-
     public static function form(Form $form): Form
     {
         $permissions = [];
 
-        foreach (self::PERMISSION_MODELS as $model) {
+        foreach (RolePermissionModels::cases() as $model) {
             $options = [];
 
-            foreach (self::PERMISSION_PREFIXES as $prefix) {
-                $options[$prefix . ' ' . strtolower($model)] = Str::headline($prefix);
+            foreach (RolePermissionPrefixes::cases() as $prefix) {
+                $options[$prefix->value . ' ' . strtolower($model->value)] = Str::headline($prefix);
             }
 
-            if (array_key_exists($model, self::MODEL_SPECIFIC_PERMISSIONS)) {
-                foreach (self::MODEL_SPECIFIC_PERMISSIONS[$model] as $permission) {
-                    $options[$permission . ' ' . strtolower($model)] = Str::headline($permission);
+            if (array_key_exists($model, Role::MODEL_SPECIFIC_PERMISSIONS)) {
+                foreach (Role::MODEL_SPECIFIC_PERMISSIONS[$model] as $permission) {
+                    $options[$permission . ' ' . strtolower($model->value)] = Str::headline($permission);
                 }
             }
 
-            $permissions[] = self::makeSection($model, $options);
+            $permissions[] = self::makeSection($model->value, $options);
         }
 
-        foreach (self::SPECIAL_PERMISSIONS as $model => $prefixes) {
+        foreach (Role::SPECIAL_PERMISSIONS as $model => $prefixes) {
             $options = [];
 
             foreach ($prefixes as $prefix) {

diff --git a/app/Models/Role.php b/app/Models/Role.php
@@ -19,6 +19,20 @@ class Role extends BaseRole
 
     public const ROOT_ADMIN = 'Root Admin';
 
+    public const MODEL_SPECIFIC_PERMISSIONS = [
+        'egg' => [
+            'import',
+            'export',
+        ],
+    ];
+
+    public const SPECIAL_PERMISSIONS = [
+        'settings' => [
+            'view',
+            'update',
+        ],
+    ];
+
     public function isRootAdmin(): bool
     {
         return $this->name === self::ROOT_ADMIN;