url function around static resource links #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrapped the static resource links in the url function to make it sync to APP_URL This would allow later on to support running in an subfolder
|
Hmm, looking at the CLA failure. It doesn't look like it added your signature or rechecked after your comment, so something probably broke. |
|
recheck |
|
Maybe it will trigger now? Update: yes it has |
|
I think I likely broke the CLA workflow for this PR by messing with the signatures in the middle. Safe to ignore if it continues to fail for this PR. |
|
The check just needs to be retriggered/retried/reexecuted. I know that that is a thing with github actions |
|
See #102 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapped the static resource links in the url function to make it sync to APP_URL
This would allow later on to support running in an subfolder