Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health page #469

Draft
wants to merge 35 commits into
base: main
Choose a base branch
from
Draft

Health page #469

wants to merge 35 commits into from

Conversation

Boy132
Copy link
Member

@Boy132 Boy132 commented Jul 8, 2024

Uses spatie/laravel-health (and shuvroroy/filament-spatie-laravel-health) to add a health page.
Also includes two custom checks: one for checking the panel version and one for checking node versions. (which also tests the wings connection indirectly)

grafik

Currently waiting for #493

Copy link
Contributor

@RMartinOscar RMartinOscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if this could be set to the user's prefered theme so we don't get Throwing flash bang

Also applies to Scramble's docs

Other then that its dope very concise

@Boy132
Copy link
Member Author

Boy132 commented Jul 8, 2024

Would be nice if this could be set to the user's prefered theme so we don't get Throwing flash bang

It already does. :)
grafik

Copy link
Contributor

@RMartinOscar RMartinOscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried it the page is cleared until i hit refresh atleast once or wait 5min since build.
I would remove that unless anyway cause i want to know if debug is on even on local env just an other safe check doesn't hurt imo

@notAreYouScared

This comment was marked as outdated.

Copy link
Member

@lancepioch lancepioch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, got a couple nitpicks

app/Providers/AppServiceProvider.php Outdated Show resolved Hide resolved
app/Providers/AppServiceProvider.php Outdated Show resolved Hide resolved
@Boy132

This comment was marked as resolved.

@notAreYouScared

This comment was marked as resolved.

@Boy132

This comment was marked as resolved.

@RMartinOscar

This comment was marked as resolved.

RMartinOscar

This comment was marked as outdated.

@Boy132 Boy132 marked this pull request as draft July 19, 2024 07:59
@Boy132
Copy link
Member Author

Boy132 commented Jul 19, 2024

I want to remove shuvroroy/filament-spatie-laravel-health but for some reason tailwind classes (colors) aren't working with the custom page/ view:
grafik

Might be related to #377?

@Boy132 Boy132 changed the title Add Health page Health page Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants