Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce the egg's file denylist more thoroughly #29

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Enforce the egg's file denylist more thoroughly #29

merged 4 commits into from
Sep 27, 2024

Conversation

QuintenQVD0
Copy link
Contributor

@QuintenQVD0 QuintenQVD0 commented Jun 15, 2024 •
edited
Loading

Changes

  • Files within the file_denylist can not be removed anymore
  • Files within that list can not be created anymore:
    afbeelding
  • If the file is put their by for example the egg install script then the user can not see what is in it
  • This includes also over SFTP
    afbeelding
    afbeelding
  • Application (tested by exec in the container) can still read the files just fine
    afbeelding

@QuintenQVD0 QuintenQVD0 marked this pull request as ready for review June 28, 2024 18:22
@QuintenQVD0 QuintenQVD0 changed the title draft: Enforce the egg's file denylist more thoroughly Enforce the egg's file denylist more thoroughly Jun 28, 2024
@QuintenQVD0
Copy link
Contributor Author

This seems to work just fine

@parkervcp parkervcp merged commit 29fa313 into pelican-dev:main Sep 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamkubi iamkubi iamkubi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuintenQVD0 @iamkubi @parkervcp