-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for variables in the configuration parser filename #34
Allow for variables in the configuration parser filename #34
Conversation
@iamkubi, IF you have some time, could you please take a look at reviewing this? |
Hi, I also had a modification to the configuration parser to propose but I can't find how to base my PR on yours. |
You are going to be have a hell of a ride as the whole configuration parser logic does not have acces to list all files as that object is never pased to it |
Does not work if you are not supposed to create the file (breaking path changes), idk if adding a "doNotCreate" flag would be better |
the fil then should be created by the install script as the configuration parser is only ment to edit files not create them (while it does that for some parsers) |
I don't think you understood what I meant. |
with this PR you would be able to use a variable in the filename and then let the user select on a dropdown with a variable to select the right config dir. but for removing create from the file that is also an option but not for me to decide if that is wanted or not |
@parkervcp could you review this? |
Changes
Edit
This works: