Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for variables in the configuration parser filename #34

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

QuintenQVD0
Copy link
Contributor

@QuintenQVD0 QuintenQVD0 commented Jul 24, 2024

Changes

Edit

This works:
afbeelding
afbeelding

@QuintenQVD0 QuintenQVD0 marked this pull request as ready for review August 15, 2024 15:51
@QuintenQVD0
Copy link
Contributor Author

@iamkubi, IF you have some time, could you please take a look at reviewing this?

@superdarki
Copy link

Hi, I also had a modification to the configuration parser to propose but I can't find how to base my PR on yours.
I was looking to add glob support as explained here : pelican-dev/panel#608

@QuintenQVD0
Copy link
Contributor Author

Hi, I also had a modification to the configuration parser to propose but I can't find how to base my PR on yours. I was looking to add glob support as explained here : pelican-dev/panel#608

You are going to be have a hell of a ride as the whole configuration parser logic does not have acces to list all files as that object is never pased to it

@superdarki
Copy link

Does not work if you are not supposed to create the file (breaking path changes), idk if adding a "doNotCreate" flag would be better

@QuintenQVD0
Copy link
Contributor Author

Does not work if you are not supposed to create the file (breaking path changes), idk if adding a "doNotCreate" flag would be better

the fil then should be created by the install script

as the configuration parser is only ment to edit files not create them (while it does that for some parsers)

@superdarki
Copy link

I don't think you understood what I meant.
The point is not of creating files or not and i'll show with an example.
For SP-Tarkov (formerly SPT-AKI), the "config" folder was name Aki_Data before 3.8 and is now named SPT_Data.
It is acutally impossible for the wings to properly parse the config files without creating waste ones and the other non used folder as I need to use the same egg for both versions.

@QuintenQVD0
Copy link
Contributor Author

I don't think you understood what I meant. The point is not of creating files or not and i'll show with an example. For SP-Tarkov (formerly SPT-AKI), the "config" folder was name Aki_Data before 3.8 and is now named SPT_Data. It is acutally impossible for the wings to properly parse the config files without creating waste ones and the other non used folder as I need to use the same egg for both versions.

with this PR you would be able to use a variable in the filename and then let the user select on a dropdown with a variable to select the right config dir. but for removing create from the file that is also an option but not for me to decide if that is wanted or not

@QuintenQVD0
Copy link
Contributor Author

@parkervcp could you review this?

@parkervcp parkervcp merged commit 5858856 into pelican-dev:main Oct 29, 2024
6 checks passed
@QuintenQVD0 QuintenQVD0 deleted the filepath_config_parser branch October 30, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants