feat: Implement rebalance allocation logic and add related error hand…#1
Merged
feat: Implement rebalance allocation logic and add related error hand…#1
Conversation
…ling - Introduced `BuildRebalanceAllocations` function to calculate allocations based on tick ranges, total amount, and slippage tolerance. - Added new error types for better validation of input parameters, including invalid tick ranges, weights, total amounts, and slippage. - Created unit tests for the rebalance allocation logic to ensure correctness and handle various edge cases. - Updated `go.mod` and `go.sum` to include the `shopspring/decimal` dependency for precise decimal arithmetic.
ytwang00
approved these changes
Feb 3, 2026
- Eliminated slippage tolerance parameter from `BuildRebalanceAllocations` function and related tests to simplify allocation calculations. - Updated error handling to focus on tick ranges, weights, and total amounts without slippage considerations. - Adjusted unit tests to reflect the removal of slippage, ensuring correctness in allocation logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ling
BuildRebalanceAllocationsfunction to calculate allocations based on tick ranges, total amount, and slippage tolerance.go.modandgo.sumto include theshopspring/decimaldependency for precise decimal arithmetic.