fix: use static COMMON_BASES fallback when GQL unavailable#17
Open
artoo-claw wants to merge 2 commits intomainfrom
Open
fix: use static COMMON_BASES fallback when GQL unavailable#17artoo-claw wants to merge 2 commits intomainfrom
artoo-claw wants to merge 2 commits intomainfrom
Conversation
The common tokens fallback was going through useCurrencies -> GQL to enrich the static token data. When GQL fails (LightLink not supported), the enriched data is undefined, making the fallback useless. Now falls back to static COMMON_BASES directly when GQL enrichment also fails, and sets loading=false to prevent infinite loading state.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The token selector shows no tokens because:
undefined, making the COMMON_BASES fallback uselessFix
When GQL enrichment fails, fall back directly to static
COMMON_BASEStoken options. Also setsloading=falsewhen using fallback to prevent infinite loading spinner.Combined with the API fix (PR #5 on uniswap-API adding
projectfield to swappable_tokens), this should make the token selector work.