Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add more data types #30

Merged
merged 24 commits into from
Sep 26, 2024
Merged

Feature: Add more data types #30

merged 24 commits into from
Sep 26, 2024

Conversation

pelmered
Copy link
Owner

@pelmered pelmered commented Mar 30, 2024 •
edited
Loading

Adds the following:

  • Engine Power (with or without unit)
  • Engine Torque (with or without unit)
  • Engine Displacement (with or without unit)
  • Fuel Consumption (with or without unit)
  • Engine Cylinders

TODO:

  • Improve tests.

Also now requires PHP 8.2+ instead of 8.1+

Fixes #31

@pelmered pelmered marked this pull request as draft March 31, 2024 10:40
@pelmered pelmered mentioned this pull request Sep 18, 2024
Closed
@pelmered pelmered self-assigned this Sep 25, 2024
@pelmered pelmered marked this pull request as ready for review September 25, 2024 23:19
Repository owner deleted a comment from codecov bot Sep 25, 2024
@pelmered pelmered merged commit 68ae2bb into main Sep 26, 2024
13 of 14 checks passed
@pelmered pelmered deleted the feature/add-more-data-types branch September 26, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pelmered pelmered

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vehicleEnginePower returns InvalidArgumentException when I use it in seeder
1 participant
@pelmered