add custom Drop that drops the clock device if needed #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folkertdev
force-pushed
the
custom-drop
branch
2 times, most recently
from
32b5295
to
52cd2f4
Compare
folkertdev
commented
Oct 4, 2023
Comment on lines
+452
to
+461
| // an error is unlikely (source: https://linux.die.net/man/2/dup2) | ||
| // | ||
| // - EBADF cannot happen, the fd we provide is valid | ||
| // - EMFILE it is unlikely that the process runs out of file descriptors | ||
| // | ||
| // The other errors are only returned by dup2 and dup3 | ||
| match unsafe { libc::dup(fd) } { | ||
| -1 => panic!("{:?}", convert_errno()), | ||
| new_fd => Self::safe_from_raw_fd(new_fd), | ||
| } |
There was a problem hiding this comment.
I don't think we can do better than this. And hey, when you run out of fd's you're doing something weird and it's not really our problem
folkertdev
force-pushed
the
custom-drop
branch
from
52cd2f4
to
22f5590
Compare
davidv1992
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is kind of the right thing to do, but does mean that the clock is no longer clone or copy