Update draft version and ignore kiss codes

This allows running NTPv5 against ourselves.
pendulum-project · Nov 1, 2023 · 0a4bcb5 · 0a4bcb5
1 parent e97701d
commit 0a4bcb5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/ntp-proto/src/packet/mod.rs b/ntp-proto/src/packet/mod.rs
@@ -942,7 +942,8 @@ impl<'a> NtpPacket<'a> {
             NtpHeader::V3(header) => header.reference_id,
             NtpHeader::V4(header) => header.reference_id,
             #[cfg(feature = "ntpv5")]
-            NtpHeader::V5(_header) => todo!("NTPv5 does not have reference IDs"),
+            // TODO NTPv5 does not have reference IDs so this should always be None for now
+            NtpHeader::V5(_header) => ReferenceId::NONE,
         }
     }
 
@@ -951,7 +952,8 @@ impl<'a> NtpPacket<'a> {
             NtpHeader::V3(header) => header.stratum == 0,
             NtpHeader::V4(header) => header.stratum == 0,
             #[cfg(feature = "ntpv5")]
-            NtpHeader::V5(_header) => todo!("NTPv5 does not have kiss codes yet"),
+            // TODO NTPv5 does not have Kiss codes so we pretend everything is always fine
+            NtpHeader::V5(_header) => false,
         }
     }
 

diff --git a/ntp-proto/src/packet/v5/mod.rs b/ntp-proto/src/packet/v5/mod.rs
@@ -12,7 +12,7 @@ pub use error::V5Error;
 use super::RequestIdentifier;
 
 #[allow(dead_code)]
-pub(crate) const DRAFT_VERSION: &str = "draft-ietf-ntp-ntpv5-00";
+pub(crate) const DRAFT_VERSION: &str = "draft-ietf-ntp-ntpv5-01";
 pub(crate) const UPGRADE_TIMESTAMP: NtpTimestamp = NtpTimestamp::from_bits(*b"NTP5NTP5");
 
 #[repr(u8)]