Rewrote introduction of readme to be more targeted. #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1099 +/- ##
=======================================
Coverage 85.31% 85.31%
=======================================
Files 54 54
Lines 14725 14729 +4
=======================================
+ Hits 12562 12566 +4
Misses 2163 2163 ☔ View full report in Codecov by Sentry. |
cikzh
requested changes
Sep 28, 2023
folkertdev
reviewed
Sep 28, 2023
README.md
Outdated
Comment on lines
32
to
33
| pollinterval: 16s, missing polls: 0 | ||
| root dispersion: 0.000351s, root delay:0.003571s |
There was a problem hiding this comment.
it it's "root dispersion" then should it not also be "poll interval"? (i know that is not in this PR but I'm noticing it now)
There was a problem hiding this comment.
made this change in #1101
davidv1992
commented
Oct 4, 2023
davidv1992
commented
Oct 4, 2023
davidv1992
commented
Oct 4, 2023
davidv1992
commented
Oct 4, 2023
Co-authored-by: Marlon Peeters <marlonp33@gmail.com> Co-authored-by: Folkert de Vries <folkert@folkertdev.nl>
|
Taken the suggestions from @cikzh, and added the spaces between poll and interval. Suggest we make a decision on a badge for the documentation in a separate PR. |
cikzh
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #977