Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add handling of NTPv5 to the server #1153

Merged
merged 8 commits into from
Oct 31, 2023
Merged

Add handling of NTPv5 to the server #1153

merged 8 commits into from
Oct 31, 2023

Conversation

tdittr
Copy link
Contributor

@tdittr tdittr commented Oct 25, 2023 •
edited
Loading

  • Fix packet deserialization
  • Fix response serialization
  • Append and check draft identification
  • Implement upgrade protocol

@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (0840493) 85.25% compared to head (3750527) 85.40%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1153      +/-   ##
==========================================
+ Coverage   85.25%   85.40%   +0.15%     
==========================================
  Files          57       57              
  Lines       15506    15691     +185     
==========================================
+ Hits        13219    13401     +182     
- Misses       2287     2290       +3
Files Coverage Δ
ntp-proto/src/packet/extension_fields.rs 93.60% <100.00%> (+0.06%) ⬆️
ntpd/src/daemon/server.rs 87.39% <100.00%> (+0.55%) ⬆️
ntp-proto/src/packet/v5/mod.rs 90.38% <97.77%> (+1.24%) ⬆️
ntp-proto/src/packet/mod.rs 84.90% <84.87%> (+0.71%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tdittr tdittr marked this pull request as ready for review October 27, 2023 06:32
@tdittr tdittr requested review from folkertdev, marlonbaeten and cikzh and removed request for folkertdev October 27, 2023 06:39
@tdittr tdittr requested review from davidv1992 and removed request for marlonbaeten and cikzh October 27, 2023 12:26
@tdittr tdittr marked this pull request as draft October 27, 2023 13:48
@tdittr tdittr marked this pull request as ready for review October 27, 2023 13:48
folkertdev
folkertdev reviewed Oct 27, 2023
View reviewed changes
ntp-proto/src/packet/v5/mod.rs
Comment on lines +125 to +126
// TODO does this match entropy handling of the rest of the system?
Self(random())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is kind of unfortunate for testing (potentially for reproducing fuzzing errors too)

@tdittr tdittr requested a review from rnijveld October 31, 2023 09:07
@marlonbaeten marlonbaeten self-requested a review October 31, 2023 09:47
@rnijveld rnijveld merged commit 39a15e9 into main Oct 31, 2023
22 checks passed
@rnijveld rnijveld deleted the v5-server-tests branch October 31, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@folkertdev folkertdev folkertdev left review comments

@marlonbaeten marlonbaeten marlonbaeten approved these changes

@rnijveld rnijveld rnijveld approved these changes

@davidv1992 davidv1992 Awaiting requested review from davidv1992

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
All NTPv5 Draft Features Implemented
Development

Successfully merging this pull request may close these issues.
5 participants
@tdittr @rnijveld @davidv1992 @marlonbaeten @folkertdev