Fix minimum MAC size this fixes a deserialization error #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdittr
force-pushed
the
fix-ef-min-length
branch
from
05b6a9c to
3bd9ac6
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1159 +/- ##
==========================================
- Coverage 85.54% 85.52% -0.03%
==========================================
Files 57 57
Lines 15720 15699 -21
==========================================
- Hits 13448 13426 -22
- Misses 2272 2273 +1
☔ View full report in Codecov by Sentry. |
marlonbaeten
approved these changes
Oct 31, 2023
rnijveld
approved these changes
Oct 31, 2023
|
@tdittr You can merge this after a rebase :) |
Before the last extension was always ignored if it was not at least 32 bytes without padding. Removed a test that did check for the wrong behavior This test checked that a too short field was not actually serialized at all, which is wrong. Making the encrypted field this short is also not possible as the nonce alone is 16bytes + 4bytes of ef header + 4 bytes NTS header...
tdittr
force-pushed
the
fix-ef-min-length
branch
from
3bd9ac6 to
ea720e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the last extension was always ignored if it was not at least 32 bytes without padding.