Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NTPv5 support to Peer #1168

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Add NTPv5 support to Peer #1168

merged 3 commits into from
Nov 1, 2023

Conversation

tdittr
Copy link
Contributor

@tdittr tdittr commented Oct 31, 2023

  • Add a state machine for protocol upgrades to the peer

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (fa80494) 85.52% compared to head (0a4bcb5) 85.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1168      +/-   ##
==========================================
+ Coverage   85.52%   85.60%   +0.07%     
==========================================
  Files          57       57              
  Lines       15699    15883     +184     
==========================================
+ Hits        13427    13597     +170     
- Misses       2272     2286      +14     
Files Coverage Δ
ntp-proto/src/packet/extension_fields.rs 93.41% <100.00%> (+0.06%) ⬆️
ntp-proto/src/packet/v5/mod.rs 90.38% <100.00%> (ø)
ntp-proto/src/time_types.rs 94.25% <100.00%> (+0.06%) ⬆️
ntp-proto/src/packet/mod.rs 85.91% <81.63%> (+0.90%) ⬆️
ntp-proto/src/peer.rs 88.55% <81.37%> (-1.62%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tdittr tdittr marked this pull request as ready for review October 31, 2023 15:12
@tdittr tdittr requested a review from davidv1992 November 1, 2023 06:59
This allows running NTPv5 against ourselves.
@davidv1992 davidv1992 merged commit 5573187 into main Nov 1, 2023
20 checks passed
@davidv1992 davidv1992 deleted the ntpv5-peeer-impl branch November 1, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants