Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Server Reference ID Bloom FIlter #1171

Merged
merged 7 commits into from
Nov 4, 2023
Merged

Conversation

tdittr
Copy link
Contributor

@tdittr tdittr commented Nov 1, 2023

No description provided.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (49a6eeb) 85.39% compared to head (512a7b3) 85.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1171      +/-   ##
==========================================
+ Coverage   85.39%   85.64%   +0.25%     
==========================================
  Files          57       58       +1     
  Lines       16122    16618     +496     
==========================================
+ Hits        13767    14233     +466     
- Misses       2355     2385      +30     
Files Coverage Δ
ntp-proto/src/lib.rs 100.00% <ø> (ø)
ntp-proto/src/packet/v5/mod.rs 100.00% <ø> (ø)
ntp-proto/src/peer.rs 87.39% <100.00%> (+1.47%) ⬆️
ntpd/src/daemon/observer.rs 73.91% <100.00%> (+0.94%) ⬆️
ntpd/src/daemon/system.rs 63.08% <100.00%> (ø)
ntp-proto/src/packet/mod.rs 88.66% <93.75%> (+0.66%) ⬆️
ntp-proto/src/system.rs 98.23% <89.47%> (-1.77%) ⬇️
ntp-proto/src/packet/extension_fields.rs 91.94% <75.00%> (-0.20%) ⬇️
ntp-proto/src/packet/v5/extension_fields.rs 96.00% <93.61%> (-4.00%) ⬇️
ntp-proto/src/packet/v5/server_reference_id.rs 88.46% <88.46%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tdittr tdittr marked this pull request as ready for review November 4, 2023 12:29
@tdittr tdittr requested a review from davidv1992 November 4, 2023 12:29
@tdittr tdittr force-pushed the server-reference-ids branch from 4378125 to 0d2e3e1 Compare November 4, 2023 12:55
@tdittr tdittr requested a review from davidv1992 November 4, 2023 13:05
@davidv1992 davidv1992 merged commit f421a48 into main Nov 4, 2023
20 checks passed
@davidv1992 davidv1992 deleted the server-reference-ids branch November 4, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants