Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a contributing guide #1186

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Add a contributing guide #1186

merged 2 commits into from
Nov 10, 2023

Conversation

rnijveld
Copy link
Member

@rnijveld rnijveld commented Nov 9, 2023

No description provided.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (65f2314) 85.47% compared to head (6b75578) 85.45%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1186      +/-   ##
==========================================
- Coverage   85.47%   85.45%   -0.03%     
==========================================
  Files          58       56       -2     
  Lines       16842    16791      -51     
==========================================
- Hits        14395    14348      -47     
+ Misses       2447     2443       -4     

see 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cikzh cikzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only a few minor suggestions

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@rnijveld rnijveld requested a review from cikzh November 10, 2023 12:55
@cikzh cikzh merged commit 659dff9 into main Nov 10, 2023
20 checks passed
@cikzh cikzh deleted the contributing-guide branch November 10, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants