Implemented status messages for ntpv5. #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1209 +/- ##
==========================================
- Coverage 85.47% 85.09% -0.39%
==========================================
Files 58 58
Lines 17077 17204 +127
==========================================
+ Hits 14596 14639 +43
- Misses 2481 2565 +84 ☔ View full report in Codecov by Sentry. |
rnijveld
reviewed
Nov 16, 2023
ntp-proto/src/packet/mod.rs
Outdated
| } | ||
| } | ||
| } | ||
|
|
||
| pub fn is_kiss(&self) -> bool { | ||
| match self.header { | ||
| NtpHeader::V3(header) => header.stratum == 0, | ||
| NtpHeader::V4(header) => header.stratum == 0, | ||
| #[cfg(feature = "ntpv5")] | ||
| // TODO NTPv5 does not have Kiss codes so we pretend everything is always fine |
There was a problem hiding this comment.
This todo no longer seems to apply?
rnijveld
reviewed
Nov 16, 2023
ntp-proto/src/packet/mod.rs
Outdated
| NtpHeader::V3(header) => header.reference_id, | ||
| NtpHeader::V4(header) => header.reference_id, | ||
| #[cfg(feature = "ntpv5")] | ||
| // Kiss code in ntpv5 is the first four bytes of the server vookie |
rnijveld
requested changes
Nov 16, 2023
tdittr
requested changes
Nov 16, 2023
Note: this is based on the current proposal from us, not yet part of the draft.
davidv1992
force-pushed
the
ntpv5-status-messages
branch
from
4fc8649 to
c77e1e3
Compare
rnijveld
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is based on the current proposal from us, not yet part of the draft.