Run tests with test keys symlinks from crate directories #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnijveld
force-pushed
the
test-keys-fixes
branch
from
32e89bb to
d01a828
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1218 +/- ##
==========================================
- Coverage 85.47% 83.68% -1.79%
==========================================
Files 58 63 +5
Lines 17077 17495 +418
==========================================
+ Hits 14596 14641 +45
- Misses 2481 2854 +373 ☔ View full report in Codecov by Sentry. |
davidv1992
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lib tests assumed that the entire repository is available, but once pushed to crates.io, only the crate itself is available. Cargo does resolve the symlink and pushes the target of that symlink to the repository though, so this should fix that.
Fixes #1214
Fixes #1215