Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

umpf: output version infos to bitbake variables during format-patch #38

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

ejoerns
Copy link
Member

@ejoerns ejoerns commented Mar 6, 2024

This sets PV to the exact umpf version.

This is especially useful when using the series.inc together with the linux-yocto.bbclass version checking which expects PV to match the full kernel version.

@ejoerns
Copy link
Member Author

ejoerns commented Mar 6, 2024

Note that this currently sets LINUX_VERSION unconditionally which might not be optimal since not all recipes are kernels.
However, I could not find an existing good way to know which software we create the patches for.
Another option might be to just omit this first of all.

umpf Outdated Show resolved Hide resolved
@michaelolbrich
Copy link
Member

Is is save to overwritePVin general. What about packages other than the kernel?

@ejoerns
Copy link
Member Author

ejoerns commented Mar 7, 2024

Is is save to overwritePVin general. What about packages other than the kernel?

You can always override PV with a custom value (other than the default taken from the file name).
If that's always desired is a different thing where I am not sure about. The advantage would be that you see the umpf version also in the generated version and compliance artifacts, etc.

It should at least be ensured that the PV value does not imply a lower version when being updated (this would also trigger buildhistory sanity check errors) but that should be the case when using dates as suffix.

This sets PV to the exact umpf version.

This is especially useful when using the series.inc together with the
linux-yocto.bbclass version checking which expects PV to match the full
kernel version.

When detecting a linux kernel, also set LINUX_VERSION to ${UMPF_BASE}.

Signed-off-by: Enrico Jörns <ejo@pengutronix.de>
@michaelolbrich michaelolbrich merged commit 48d63ec into pengutronix:master Mar 7, 2024
2 checks passed
@ejoerns ejoerns deleted the bb-pv branch March 7, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants