Fix runtime crash #620
Merged
Fix runtime crash #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
meiron03
commented
Aug 30, 2024
meiron03
commented
- Fix dependency issues
- Add try/catch statements to prevent app from crashing when network requests fail
- Additional bug fixes related to widgets, laundry, and dining
- Update ktlint to 1.3.1
Two imports from jCenter (com.eightbitlab:supportrenderscriptblur:1.0.2 and com.eightbitlab:blurview:1.5.0) no longer exist which was causing the app to no longer build. I removed the first import since we no longer use this library. The second module was used by 'com.github.searchy2:CustomAlertViewDialogue:2.6.1' so I excluded it and instead added the newer version which is on jitpack. Also, jCenter was removed from repositories since it has been deprecated for a while and we no longer need it. Finally, dependencies in build.gradle were sorted for readability.
…from crashing the app
… declared as a separate function, the tab is not set to dining when widget is clicked.
Somehow one of the libraries broke, so I reverted to an older version.
baronhsieh2005
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
The program is running smoothly without fatal crashes when runtime exceptions are thrown and the NoSuchElementExceeption is also no longer being thrown after the LaundryViewModel logic change (not removing an empty rooms list anymore). Laundry functionality might need to be further tested after the backend issues are resolved but currently our app is back to running normally. Thank you so much Aaron!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.